Implement KnownFragmentNames validator

vektah · Jul 11, 2018 · fb3fc1d · fb3fc1d
1 parent e01bb21
commit fb3fc1d
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/validator/known_fragment_names.go b/validator/known_fragment_names.go
@@ -0,0 +1,20 @@
+package validator
+
+import (
+	"fmt"
+
+	"github.com/vektah/gqlparser"
+)
+
+func init() {
+	addRule("KnownFragmentNames", func(observers *Events, addError addErrFunc) {
+		observers.OnFragmentSpread(func(walker *Walker, parentDef *gqlparser.Definition, fragmentDef *gqlparser.FragmentDefinition, fragmentSpread *gqlparser.FragmentSpread) {
+			if fragmentDef != nil {
+				return
+			}
+
+			message := fmt.Sprintf(`Unknown fragment "%s".`, fragmentSpread.Name)
+			addError(Message(message))
+		})
+	})
+}
diff --git a/validator/validate_test.go b/validator/validate_test.go
@@ -40,6 +40,7 @@ func TestSpec(t *testing.T) {
 	t.Run("FragmentsOnCompositeTypes", runSpec(schemas, deviations, "../spec/validation/FragmentsOnCompositeTypes.yml"))
 	t.Run("KnownArgumentNames", runSpec(schemas, deviations, "../spec/validation/KnownArgumentNames.yml"))
 	t.Run("KnownDirectives", runSpec(schemas, deviations, "../spec/validation/KnownDirectives.yml"))
+	t.Run("KnownFragmentNames", runSpec(schemas, deviations, "../spec/validation/KnownFragmentNames.yml"))
 
 	t.Run("LoneAnonymousOperation", runSpec(schemas, deviations, "../spec/validation/LoneAnonymousOperation.yml"))
 

diff --git a/validator/walk.go b/validator/walk.go
@@ -14,6 +14,7 @@ type Events struct {
 	field            []func(walker *Walker, parentDef *gqlparser.Definition, fieldDef *gqlparser.FieldDefinition, field *gqlparser.Field)
 	fragment         []func(walker *Walker, parentDef *gqlparser.Definition, fragment *gqlparser.FragmentDefinition)
 	inlineFragment   []func(walker *Walker, parentDef *gqlparser.Definition, inlineFragment *gqlparser.InlineFragment)
+	fragmentSpread   []func(walker *Walker, parentDef *gqlparser.Definition, fragmentDef *gqlparser.FragmentDefinition, fragmentSpread *gqlparser.FragmentSpread)
 	directive        []func(walker *Walker, parentDef *gqlparser.Definition, directiveDef *gqlparser.DirectiveDefinition, directive *gqlparser.Directive, location gqlparser.DirectiveLocation)
 	directiveList    []func(walker *Walker, parentDef *gqlparser.Definition, directives []gqlparser.Directive, location gqlparser.DirectiveLocation)
 	value            []func(walker *Walker, value gqlparser.Value)
@@ -31,6 +32,9 @@ func (o *Events) OnFragment(f func(walker *Walker, parentDef *gqlparser.Definiti
 func (o *Events) OnInlineFragment(f func(walker *Walker, parentDef *gqlparser.Definition, inlineFragment *gqlparser.InlineFragment)) {
 	o.inlineFragment = append(o.inlineFragment, f)
 }
+func (o *Events) OnFragmentSpread(f func(walker *Walker, parentDef *gqlparser.Definition, fragmentDef *gqlparser.FragmentDefinition, fragmentSpread *gqlparser.FragmentSpread)) {
+	o.fragmentSpread = append(o.fragmentSpread, f)
+}
 func (o *Events) OnDirective(f func(walker *Walker, parentDef *gqlparser.Definition, directiveDef *gqlparser.DirectiveDefinition, directive *gqlparser.Directive, location gqlparser.DirectiveLocation)) {
 	o.directive = append(o.directive, f)
 }
@@ -189,6 +193,10 @@ func (w *Walker) walkSelection(parentDef *gqlparser.Definition, it gqlparser.Sel
 	case gqlparser.FragmentSpread:
 		def := w.Document.GetFragment(it.Name)
 
+		for _, v := range w.Observers.fragmentSpread {
+			v(w, parentDef, def, &it)
+		}
+
 		var nextParentDef *gqlparser.Definition
 		if def != nil {
 			nextParentDef = w.Schema.Types[def.TypeCondition.Name()]