Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce variables #48

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Coerce variables #48

merged 2 commits into from
Jul 25, 2018

Conversation

vektah
Copy link
Owner

@vektah vektah commented Jul 24, 2018 •
edited
Loading

Validation does not look at variables, so the result of validating a query can be cached.

This PR implements variable coercion

Follow up PR to add in hooks for scalar coercion hooks.

@vektah vektah force-pushed the coerce-variables branch from 898526d to dba1c80 Compare July 25, 2018 05:01
mathewbyrne
mathewbyrne approved these changes Jul 25, 2018
View reviewed changes
Copy link
Collaborator

@mathewbyrne mathewbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vektah vektah merged commit b346265 into master Jul 25, 2018
@vektah vektah deleted the coerce-variables branch July 25, 2018 05:35
@vektah vektah mentioned this pull request Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewbyrne mathewbyrne mathewbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vektah @mathewbyrne