Adding pretty structured logging support #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LandonTClipp
changed the title
|
I will leave this PR up for a week or two for comments. |
Fixing tests and removing some keys Removing all Printfs that were used for logging Moving argument logs over to zerolog Fix bug with log
|
This PR is going to be part of the 2.0.0-alpha.1 tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds structured logging to mockery and replaces calls to fmt.Print* with zerolog. Structured part of logging is passed around via context.
I don't know if I like forcing functions to accept
ctx, but that is how I generally pass structured logs around in my go projects. That's quite a long debate.