Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to avoid undersore in var names #834

Merged

Conversation

alexandear
Copy link
Contributor

Description

The PR renames variables and structs to follow camelCase naming convention.

According to the https://go.dev/doc/effective_go#mixed-caps

Finally, the convention in Go is to use MixedCaps or mixedCaps rather than underscores to write multiword names.

Additionally, enables revive.var-naming linter to enforce that in future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Run tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp LandonTClipp merged commit 5a0ad1c into vektra:master Oct 23, 2024
4 checks passed
sonalys pushed a commit to sonalys/mockery that referenced this pull request Nov 8, 2024
…scores

Refactor to avoid undersore in var names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants