be able to pass userId to addFile (API) #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menelike the logic behind current implementation is simple - always return Well, if we are going to let set an |
|
@dr-dimitru sorry I missed that one, hope it worked out fine |
|
Yes, already pushed to dev |
dr-dimitru
added a commit
that referenced
this pull request
Dec 15, 2016
- NPM dependencies update - Support for updated *Buffer* API on node >= 6.* - Methods `addFile`, `write` and `load` now supports `userId` option, see #305 - Fix for unfinished uploads, now files is removed by upload TTL. See #267, thanks to @ck23onGithub - Better FS-stream management on server. Less memory and CPU consumption. Only one descriptor per upload. Fix FS-permissions - `.unlink()` method now supports callback - Docs for [MUP/Docker integration](https://github.com/VeliovGroup/Meteor-Files/wiki/MeteorUp-( MUP)-Usage) - Fix #293 - Fix #299 - BEtter AWS dos, see #282 - `storagePath` now always is function, if *String* is passed - it will be wrapped into function - Please participate at [this thread](#309) to give a right path for Meteor-Files v2.0
Merged
dr-dimitru
added a commit
that referenced
this pull request
Dec 15, 2016
v1.7.6 - NPM dependencies update - Support for updated *Buffer* API on node >= 6.* - Methods `addFile`, `write` and `load` now supports `userId` option, see #305 - Fix for unfinished uploads, now files is removed by upload TTL. See #267, thanks to @ck23onGithub - Better FS-stream management on server. Less memory and CPU consumption. Only one descriptor per upload. Fix FS-permissions - `.unlink()` method now supports callback - Docs for [MUP/Docker integration](https://github.com/VeliovGroup/Meteor-Files/wiki/MeteorUp-(MUP)-Usage) - Fix #293 - Fix #299 - BEtter AWS dos, see #282 - `storagePath` now always is function, if *String* is passed - it will be wrapped into function - Please participate at [this thread](#309) to give a right path for Meteor-Files v2.0
|
Published in v1.7.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #298
Do we need to to set userId to null? Isn't it better to skip that (userId === undefined)?
no expert in CoffeeScript, review advised