#841 rewrite input base into composable #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed errors in terminal
Renamed base-composable.ts to base.ts
velis74
requested changes
Oct 30, 2023
| }); | ||
| const ckeditor = CKEditor.component; | ||
|
|
||
| interface Props extends BaseProps {} |
There was a problem hiding this comment.
Tole vem, da je v TS res težko, ampak a se tegale boilerplate-a res ne da zmanjšat? Tudi v tistih komponentah, kjer se propsi in emiti ne raztegujejo ne?
There was a problem hiding this comment.
Do nedavnega je bil odgovor: Ne. Se ko sem nazadnje testiral, to ni bilo mogoce.
Ocitno pa so v zadnjih verzijah slednje popravili in lahko uporabljas importane interface za definiranje propov as is.
Tako da se to tudi da popraviti.
Za emite obstaja se en issue -> trenutno se v consoli izpise kar nekaj warningov, sem odprl ticket na vue.
Fixed git comments: - blank line - valueA -> valueDate -
velis74
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.