move binary downloading into plugin file

backend/pkg/velocity/build/parameter.go

@@ -4,17 +4,11 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"net/http"
-	"net/url"
 	"os"
 	"time"
 
-	"go.uber.org/zap"
-
-	"github.com/gosimple/slug"
 	"github.com/velocity-ci/velocity/backend/pkg/exec"
 	"github.com/velocity-ci/velocity/backend/pkg/velocity/config"
-	"github.com/velocity-ci/velocity/backend/pkg/velocity/logging"
 )
 
 func getSecrets(params map[string]*Parameter) (r []string) {
@@ -122,47 +116,6 @@ type BackupResolver interface {
 	Resolve(paramName string) (string, error)
 }
 
-func getBinary(projectRoot, u string, writer io.Writer) (binaryLocation string, _ error) {
-
-	parsedURL, err := url.Parse(u)
-	if err != nil {
-		return "", err
-	}
-
-	binaryLocation = fmt.Sprintf("%s/.velocityci/plugins/%s", projectRoot, slug.Make(parsedURL.Path))
-
-	if _, err := os.Stat(binaryLocation); os.IsNotExist(err) {
-		logging.GetLogger().Debug("downloading binary", zap.String("from", u), zap.String("to", binaryLocation))
-		writer.Write([]byte(fmt.Sprintf("Downloading binary: %s", parsedURL.String())))
-		outFile, err := os.Create(binaryLocation)
-		if err != nil {
-			return "", err
-		}
-		defer outFile.Close()
-		resp, err := http.Get(u)
-		if err != nil {
-			return "", err
-		}
-		defer resp.Body.Close()
-
-		size, err := io.Copy(outFile, resp.Body)
-		if err != nil {
-			return "", err
-		}
-		writer.Write([]byte(fmt.Sprintf(
-			"Downloaded binary: %s to %s. %d bytes",
-			parsedURL.String(),
-			binaryLocation,
-			size,
-		)))
-
-		logging.GetLogger().Debug("downloaded binary", zap.String("from", u), zap.String("to", binaryLocation), zap.Int64("bytes", size))
-		outFile.Chmod(os.ModePerm)
-	}
-
-	return binaryLocation, nil
-}
-
 func getExportedParameterName(pMapping map[string]string, exportedParam string) string {
 	if val, ok := pMapping[exportedParam]; ok {
 		return val

backend/pkg/velocity/build/plugin.go

@@ -0,0 +1,54 @@
+package build
+
+import (
+	"fmt"
+	"io"
+	"net/http"
+	"net/url"
+	"os"
+
+	"github.com/gosimple/slug"
+	"github.com/velocity-ci/velocity/backend/pkg/velocity/logging"
+	"go.uber.org/zap"
+)
+
+func getBinary(projectRoot, u string, writer io.Writer) (binaryLocation string, _ error) {
+
+	parsedURL, err := url.Parse(u)
+	if err != nil {
+		return "", err
+	}
+
+	binaryLocation = fmt.Sprintf("%s/.velocityci/plugins/%s", projectRoot, slug.Make(parsedURL.Path))
+
+	if _, err := os.Stat(binaryLocation); os.IsNotExist(err) {
+		logging.GetLogger().Debug("downloading binary", zap.String("from", u), zap.String("to", binaryLocation))
+		writer.Write([]byte(fmt.Sprintf("Downloading binary: %s", parsedURL.String())))
+		outFile, err := os.Create(binaryLocation)
+		if err != nil {
+			return "", err
+		}
+		defer outFile.Close()
+		resp, err := http.Get(u)
+		if err != nil {
+			return "", err
+		}
+		defer resp.Body.Close()
+
+		size, err := io.Copy(outFile, resp.Body)
+		if err != nil {
+			return "", err
+		}
+		writer.Write([]byte(fmt.Sprintf(
+			"Downloaded binary: %s to %s. %d bytes",
+			parsedURL.String(),
+			binaryLocation,
+			size,
+		)))
+
+		logging.GetLogger().Debug("downloaded binary", zap.String("from", u), zap.String("to", binaryLocation), zap.Int64("bytes", size))
+		outFile.Chmod(os.ModePerm)
+	}
+
+	return binaryLocation, nil
+}