This repository has been archived by the owner on May 31, 2024. It is now read-only.
Update in preparation for v6 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsrzf
commented
Jan 15, 2021
| @@ -43,8 +43,8 @@ module.exports = { | |||
| // Don't allow unused labels. | |||
| 'no-unused-labels': 'off', | |||
|
|
|||
| // Disallow the 'var' keyword. | |||
| 'no-var': 'error', | |||
There was a problem hiding this comment.
no-var is now included in the Standard config.
| @@ -55,59 +55,6 @@ module.exports = { | |||
| // Require the radix argument to parseInt to avoid unintentionally allowing hex or octal. | |||
| radix: 'error', | |||
|
|
|||
| // Naming conventions. The TypeScript rule is much more complete and configurable than ESLint's. | |||
| camelcase: 'off', | |||
| '@typescript-eslint/naming-convention': [ | |||
There was a problem hiding this comment.
@typescript-eslint/naming-convention now requires type information, which means it can only be run on TypeScript files. I've moved it below. camelcase will still apply to JS files.
| @@ -156,6 +103,7 @@ module.exports = { | |||
| 'react/jsx-handler-names': 'off', | |||
|
|
|||
| // We use TypeScript so don't usually need PropTypes. | |||
| 'react/no-unused-prop-types': 'off', | |||
There was a problem hiding this comment.
This was flagging false positives in some TypeScript code.
| @@ -311,13 +318,6 @@ module.exports = { | |||
| 'no-array-constructor': 'off', | |||
| '@typescript-eslint/no-array-constructor': 'error', | |||
|
|
|||
| // Don't allow extra semi-colons. | |||
| 'no-extra-semi': 'off', | |||
There was a problem hiding this comment.
This is covered by Prettier, and conflicts with some of Prettier's opinions.
| @@ -276,12 +283,6 @@ module.exports = { | |||
| { assertionStyle: 'as' }, | |||
| ], | |||
|
|
|||
| // Prefer interfaces over type literals (type T = { ... }). | |||
| '@typescript-eslint/consistent-type-definitions': [ | |||
There was a problem hiding this comment.
It turns out that interfaces and type literals are not completely equivalent, and there are use cases for type literals over interfaces. This rule does not account for those use cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No major changes in this release, but some rules did change, so it will be a new major version. The primary goal here is to get in the newest major version of
@typescript-eslintpackages.Changes: