This repository has been archived by the owner on May 31, 2024. It is now read-only.
Update dependencies; add some new rules #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a few things: * Updates dependencies, including some major version bumps (eslint, @typescript-eslint) * Add eslint-plugin-react-hooks for React hook lint rules * Add eslint-plugin-jsx-a11y, which create-react-app also uses. Only a few rules enabled for now, but we should aim to get to at least the same configuration as create-react-app. * Make config dependencies non-peer dependencies, since it's now possible with eslint 6. * Add dev dependencies and a lint script to this repo to make it easier to test the validity of the configuration. Tested configuration against Web Register and Monocle. Some new issues, but pretty valid ones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
Tested configuration against Web Register and Monocle. Some new issues, but pretty valid ones.