-
Notifications
You must be signed in to change notification settings - Fork 2
Community track for the win! #11
base: master
Are you sure you want to change the base?
Conversation
Moving each track into its own file is great but it would've been nice to do it in a separate commit so we can see what changes you made for this particular track ;) |
Ok if we rely on the diffing for the discussion I am gonna duplicate my changes back in |
…ts.js for comparison with diff
Done! Easier to compare now. |
"trailingComma": "none", | ||
"tabWidth": 2, | ||
"printWidth": 120, | ||
"semi": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neither consistent with the existing style nor our usual style at Vend 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know this is the case. Since I have all my nice tooling set up to automatically format code, I tweaked that file to follow the current style in that specific Medium repo. They use different rules from us.
I am very keen though to create a PR that makes the entire repo. follow standardjs
and no semicolons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think the examples need work. Many of them feel to me like they could fall under one of the other tracks rather than community. Also some grammar suggestions.
constants.js
Outdated
"Treats colleagues and clients with respect", | ||
"Joins groups or committees outside regular duties" | ||
"Participates in team activities and events", | ||
"Joins and participates to internal groups or initiatives" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"participates in"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Thanks.
I struggle with some idiomatic English constructs.
constants.js
Outdated
"Brought a small gift back from vacation for the team", | ||
"Constantly celebrated the team achievements", | ||
"Participated meaningfully to the team meetings", | ||
"Paired up with X to help them learn or unblock a situation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels more like accomplishment or mentorship to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "paired up" in my mind is more like the occasional help. Mentorship is more deliberate and defined. But if that can be source of confusion, maybe this is badly expressed or should be removed, yes.
The other 2 I want to express that celebrating the team achievements and other team members work, helps build a great community (within the team), and that just sitting in meetings and answering is not enough for that level, one needs to be active.
If that can still find a place here, I am keen for better wording.
constants.js
Outdated
"Brought a small gift back from vacation for the team", | ||
"Constantly celebrated the team achievements", | ||
"Participated meaningfully to the team meetings", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"meaningfully in", but I think this also overlaps with org design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another wrong "to".
Yes organisation design and team as a community can overlap a bit. I need to look at the other track to see if I can define the boundaries clearly.
"Refactored a multitude of legacy PHP issues", | ||
"Acted as sole maintainer of Jenkins for years" | ||
"Created an automated testing pipeline for the team project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe craft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be. I also need to look deeper into craft for comparison. Overall I am not completely sold about what Medium puts at that level for community. I am not certain community should be "too technical" but more on the people side.
This is my interpretation but if that could help put a clear boundary around Community vs other tracks that could solve some of our overlap problems.
constants.js
Outdated
"Takes on large amounts of tedious grunt work for the team without being asked" | ||
], | ||
examples: [ | ||
"Devoted large amount of time to helping outside direct responsibilities", | ||
"Took on setting up tooling for the project the team in woerking on", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is working on"
This feels like it might be craft or perhaps one of the technical tracks. This could make sense if the person took on setting up tooling because no one else wanted to do it, but I don't think that's clear from this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes maybe that example could be reworded better.
I was not sold on the original example that tends to be too general of an example. More concrete examples can help reduce interpretation issues.
"Created an automated testing pipeline for the team project", | ||
"Acted as sole maintainer of Jenkins for years", | ||
"Created and applied a team onboarding programme for newcomers", | ||
"Ran training sessions on React for the entire team", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentorship?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I admit.
The training session and onboarding programme are mentorship activities as well.
2 first two I don't think so. The Jenkins one I got inspiration from another example that was already in Community. Again I wonder if these are not "too technical" examples and should be more soft skills.
constants.js
Outdated
"Acted as sole maintainer of Jenkins for years", | ||
"Created and applied a team onboarding programme for newcomers", | ||
"Ran training sessions on React for the entire team", | ||
"Improved our team development experience by introducing X", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on what X is, this might be craft or one of the technical tracks. But if X is "GIF selector browser plugin" then it might fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes now I see X is a bad idea. Too open to interpretation.
When I though of X, I was thinking like "Improved our team development experience by introducing a static analyser tool".
constants.js
Outdated
"Challenged and corrected exclusionary behaviour or policies", | ||
"Organised cross team events to help mix and match people", | ||
"Set up a regular event for the whole office to share achievements, failures and learnings", | ||
"Created and led a cross-teams engineer rotation and immersion programme" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cross-team", no "s"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
constants.js
Outdated
"Stayed positive and improved team morale during period after layoffs" | ||
"Stayed positive and improved team morale during period after layoffs", | ||
"Helped team X move forward with their work by sharing knowledge/pairing...", | ||
"Constantly enabled others as the specialist in X", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should aim to replace "X" with an actual thing so that the example is specific. Depending on what X is, this might fall under a different track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally, it is confusing.
"Helped another team move forward with their work by sharing knowledge/pairing..."
"Constantly enabled others as the specialist in Go"
constants.js
Outdated
"Stayed positive and improved team morale during period after layoffs", | ||
"Helped team X move forward with their work by sharing knowledge/pairing...", | ||
"Constantly enabled others as the specialist in X", | ||
"Raised up and clearly communicated risks and impediments on behalf of X", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same "X" issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was: "Raised up and clearly communicated risks and impediments on behalf of another team member"
That example in itself is strange though. I put it there because there was something along those lines mentioned in something I read in Medium/Confluence or the Snowflake while I was working on that. But I can't put my finger on it now.
Thanks @edsrzf for taking the time to look at my PR. |
constants.js
Outdated
summary: "Builds community internally, gives of themself to the team, and champions and extols company values", | ||
summary: "Help build the community internally.", | ||
description: | ||
"Live and champion the company values within the team and across the company. Contribute to make our environment a better, more enjoyable and supportive place for everyone.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live and champion the company values within the team and across the company. Contribute to make our environment a better, more enjoyable and supportive place for everyone.
It would be nice to re-write this description to sound more like the other ones. The way we've done it (when I say we I actually mean Medium) is to have:
- the summary is a short, present tense (with no pronouns):
[the engineer] does something
- the description is from Vend's point of view and emphasises on what we're looking for in an engineer and what we thrive for:
We value x, we want to be y, we need someone like z
- example behaviours use the present tense, like the summary (with no pronouns)
- example tasks use use the past tense (with no pronouns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Giving it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rewritten it from Vend's point of view.
Medium blob: https://medium.com/s/engineering-growth-framework/engineering-growth-tracks-b1fad620787e
The community track represents one's internal involvement to make the company a better environment. It is different from the evangelism track for example that represents one's external involvement as a representative of the company.