Skip to content

chore: Update node sass command to use "sass" instead of "node-sass" #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Vignesh-vendastian
Copy link
Contributor

Purpose

The node-scss package had a complete depreciation in July. As a result, the setup script is returning an error.

image

Depreciation notice - Link
The proper alternative for that outdated package is to use scss. sass package is also expose the same JavaScript API.

Explanation of the approach

  • Swap out node-scss with scss in the installation command

@mahisiva87
Copy link

@vendasta/ioscotw

Copy link

@arunrajkhumar arunrajkhumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution. 🎉

@Vignesh-vendastian Vignesh-vendastian merged commit 7317868 into master Sep 5, 2024
1 check passed
@Vignesh-vendastian Vignesh-vendastian deleted the update-node-scss branch September 5, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants