Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

[Main] Introduce dynamic colors #12

Merged
merged 15 commits into from
Jul 15, 2023
Merged

[Main] Introduce dynamic colors #12

merged 15 commits into from
Jul 15, 2023

Conversation

nexpid
Copy link
Contributor

@nexpid nexpid commented Jul 12, 2023 •
edited
Loading

adds a __vendetta_syscolors property to window, and a syscolors: { prop: "__vendetta_syscolors" } property to window.__vendetta_loader.features

please lmk if/when this PR is ready to merge so I can remove the installation guide in readme

nexpid and others added 13 commits July 10, 2023 10:34
@nexpid
Copy link
Contributor Author

nexpid commented Jul 12, 2023

sorry for the commit spam lmao

@wingio
Copy link
Member

wingio commented Jul 12, 2023

Please remove Gson, we already have kotlinx serialization

@nexpid
Copy link
Contributor Author

nexpid commented Jul 13, 2023

ah ok im new to kotlin lmao

@nexpid
[Main] More changes (check detailed description)
6bd13a1 
- use kotlin serializer instead of gson
- bump target SDK to 33
- fix broken link in README
@nexpid
Copy link
Contributor Author

nexpid commented Jul 13, 2023

should be fine now

@wingio
Copy link
Member

wingio commented Jul 14, 2023

Can you clarify in the README that the instructions are for testing locally, also can you remove any references to your fork and instead refer to the actions build in this repo

@nexpid
Copy link
Contributor Author

nexpid commented Jul 15, 2023

Can you clarify in the README that the instructions are for testing locally, also can you remove any references to your fork and instead refer to the actions build in this repo

i reverted the README, is it ready to merge now? (squash and merge would be ideal lol)
i could also make a PR at https://github.com/Vendetta-mod/Vendetta to implement the syscolors property into metro itself, instead of just reading from window.__vendetta_syscolors

@wingio wingio merged commit 2f3aec2 into vendetta-mod:master Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nexpid @wingio @riichi67