fix(admin-ui): Add unique location id for prod detail variants table

vendure-ecommerce · Oct 17, 2023 · ce2b251 · ce2b251
1 parent 08ad982
commit ce2b251
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/...ages/admin-ui/src/lib/catalog/src/components/product-detail/product-detail.component.html b/...ages/admin-ui/src/lib/catalog/src/components/product-detail/product-detail.component.html
@@ -198,6 +198,7 @@
                 <ng-template #variantList>
                     <vdr-product-variant-list
                         [productId]="this.id"
+                        dataTableId="product-detail-variants-list"
                         [hideLanguageSelect]="true"
                     ></vdr-product-variant-list>
                 </ng-template>

diff --git a/...i/src/lib/catalog/src/components/product-variant-list/product-variant-list.component.html b/...i/src/lib/catalog/src/components/product-variant-list/product-variant-list.component.html
@@ -7,7 +7,7 @@
 </vdr-page-block>
 <vdr-data-table-2
     class="mt-2"
-    id="product-variant-list"
+    [id]="dataTableId || 'product-variant-list'"
     [items]="items$ | async"
     [itemsPerPage]="itemsPerPage$ | async"
     [totalItems]="totalItems$ | async"

diff --git a/...-ui/src/lib/catalog/src/components/product-variant-list/product-variant-list.component.ts b/...-ui/src/lib/catalog/src/components/product-variant-list/product-variant-list.component.ts
@@ -1,7 +1,7 @@
 import { Component, Input, OnInit } from '@angular/core';
 import { marker as _ } from '@biesbjerg/ngx-translate-extract-marker';
 import {
-    LogicalOperator,
+    DataTableLocationId,
     ProductVariantListQueryDocument,
     TypedBaseListComponent,
 } from '@vendure/admin-ui/core';
@@ -17,6 +17,7 @@ export class ProductVariantListComponent
 {
     @Input() productId?: string;
     @Input() hideLanguageSelect = false;
+    @Input() dataTableId: DataTableLocationId | undefined;
     readonly customFields = this.getCustomFieldConfig('ProductVariant');
     readonly filters = this.createFilterCollection()
         .addIdFilter()

diff --git a/...ui/src/lib/core/src/shared/components/data-table-2/data-table-custom-component.service.ts b/...ui/src/lib/core/src/shared/components/data-table-2/data-table-custom-component.service.ts
@@ -9,6 +9,7 @@ export type DataTableLocationId =
     | 'edit-options-list'
     | 'manage-product-variant-list'
     | 'customer-order-list'
+    | 'product-detail-variants-list'
     | string;
 
 export type DataTableColumnId =