Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customers to be updated on existing orders #2505

Closed
kyunal opened this issue Nov 3, 2023 · 4 comments
Closed

Allow customers to be updated on existing orders #2505

kyunal opened this issue Nov 3, 2023 · 4 comments

Comments

@kyunal
Copy link
Contributor

kyunal commented Nov 3, 2023

Is your feature request related to a problem? Please describe.
We've had multiple occasions now where recurring customers mistyped their e-mail address, resulting in two (otherwise identical) customers to be created. As far as I understand, it currently isn't possible to merge two customers or to change the order's customer, making this a chore to make right with the customer.
This also leaves the wrong order isolated from the original customer, meaning it won't ever show up in their history etc. in case they have an account or are making an account in the future with the correct e-mail address.

Describe the solution you'd like
The API and Admin UI should allow an order's customer to be changed.

Describe alternatives you've considered
Merging the customers would also be an option, but most likely more difficult to implement.

Additional context
I think this isn't really a special use-case, as I said it happened multiple times to us and really is painful to deal with. We don't want to touch the database, hence we have always found other workarounds such as asking the customer for a second e-mail address they have, but this is really customer unfriendly.
In an ideal world we could also just re-send the e-mails prior to this event, but I think this would necessitate re-triggering an event, which is probably a dangerous thing to do.

@michaelbromley
Copy link
Member

Coming in the next minor:

Untitled.video.mp4

michaelbromley added a commit that referenced this issue Jan 19, 2024
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Jan 19, 2024
@martijnvdbrug
Copy link
Collaborator

We have a plugin that does that: https://pinelab-plugins.com/plugin/vendure-plugin-change-order-customer/

@michaelbromley If there are any plans to include this in core, feel free to merge our plugin into @vendure/core, and we can maintain it in core instead of a separate plugin
https://github.com/Pinelab-studio/pinelab-vendure-plugins/tree/main/packages/vendure-plugin-change-order-customer

@michaelbromley
Copy link
Member

@martijnvdbrug Yes, this is now in core and will be part of v2.2. I didn't know about your plugin, but it is very similar - the new implementation just does some extra things like checking channel membership and also adding an order history entry.

@martijnvdbrug
Copy link
Collaborator

@martijnvdbrug Yes, this is now in core and will be part of v2.2. I didn't know about your plugin, but it is very similar - the new implementation just does some extra things like checking channel membership and also adding an order history entry.

It was published today😅 I wasn't aware of this being in core...

@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚀 Shipped
Development

No branches or pull requests

3 participants