Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation Custom Fields on StockLocation not Updating #2804

Closed
dylviz opened this issue Apr 22, 2024 · 1 comment
Closed

Relation Custom Fields on StockLocation not Updating #2804

dylviz opened this issue Apr 22, 2024 · 1 comment
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@dylviz
Copy link
Contributor

dylviz commented Apr 22, 2024

Describe the bug
Update() method in stock location service file is missing call to update the relations. See code here:

async update(ctx: RequestContext, input: UpdateStockLocationInput): Promise<StockLocation> {

To Reproduce

  1. Create a custom relation on the StockLocation entity within your plugin
  2. Run dev-server, open admin-ui
  3. Modify the customField on StockLocation entity then click Update()
  4. Navigate away from the page and back again and see that your update is not shown
  5. This is because your update wasn't saved
  6. verified in the DB that the updated relation is not modified/saved

Expected behavior
Updated relation should be shown in the admin-ui and in the DB StockLocation table

Environment (please complete the following information):

  • Verified bug on V2.1.7 and V2.2.0
  • @vendure/core version: > 2.1.7+

Additional Context
Will link PR

@dylviz dylviz added the type: bug 🐛 Something isn't working label Apr 22, 2024
dylviz added a commit to dylviz/vendure that referenced this issue Apr 22, 2024
The Stock Location update method was not updating relation customFields

Refs: vendure-ecommerce#2804
@dylviz
Copy link
Contributor Author

dylviz commented Apr 22, 2024

Sorry, it's not letting me edit the issue to link the PR: #2805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants