Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: product soft delete check deletedAt option group before trying to delete #2706

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: product soft delete check deletedAt option group before trying to delete #2706

merged 1 commit into from
Apr 3, 2024

Conversation

seminarian
Copy link
Contributor

@seminarian seminarian commented Feb 28, 2024 •
edited
Loading

Description

Ran into an issue where an OptionGroup which was already deleted was attempted to be deleted again.
getEntityOrThrow inside the deleteGroupAndOptionsFromProduct failed the softDelete call on ProductService.

@michaelbromley michaelbromley merged commit 16add4a into vendure-ecommerce:minor Apr 3, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seminarian @michaelbromley