perf(core): upgrade sql requests for more performant memory usage with big datasets #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbromley
merged commit 65888cb
into
vendure-ecommerce:minor
9 of 12 checks passed
|
Wow! Incredible how much of an impact this little change makes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrade is needed if you want to remove a product with more than 200 variants and 7 languages. If you leave this data in one SQL query, the memory consumption on the server for data processing reaches 10k MB in the test environment more than 800mb. The presented improvement reduces memory consumption to 1-5mb
Breaking changes
Does this PR include any breaking changes we should be aware of?
Screenshots
Before
After
Checklist
📌 Always:
👍 Most of the time: