allow custom Ad structure

venediktov · Apr 21, 2024 · 7470c95 · 7470c95
1 parent 4ff7575
commit 7470c95
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/rtb/core/ad_selector.hpp b/rtb/core/ad_selector.hpp
@@ -52,6 +52,12 @@ static auto chain_function(BidRequest &&req, Impression &&imp, Arg &&arg,
 
 } // namespace detail
 
+template <typename T>
+concept is_vanilla_standard_ad = requires(T value) {
+ value.auth_bid_micros;
+ value.max_bid_micros;
+};
+
 template<typename BudgetManager, typename Ad>
 class ad_selector {
  public:
@@ -66,10 +72,16 @@ class ad_selector {
  template<typename BidRequest, typename Impression, typename HeadArg , typename... Funcs>
  auto select(BidRequest&& req, Impression&& imp, HeadArg&& head, Funcs... funcs) {
  auto ads = detail::chain_function( std::forward<BidRequest>(req), std::forward<Impression>(imp), std::forward<HeadArg>(head), funcs...);
- if(selection_algo) {
+ if (selection_algo) {
  return selection_algo(ads);
+ } else {
+ if constexpr ( is_vanilla_standard_ad<Ad>) {
+ return algorithm::calculate_max_bid(ads);
+ } else {
+ // TODO: add compile time warning for using dummy algo
+ return std::unique_ptr<Ad>{};
+ }
  }
- return algorithm::calculate_max_bid(ads);
  }
 
  template<typename BudgetCache , typename CampaignId>

diff --git a/rtb/core/bidder.hpp b/rtb/core/bidder.hpp
@@ -92,7 +92,10 @@ namespace vanilla {
  bid.id = boost::uuids::to_string(bidid); // TODO check documentation
  // Is it the same as response.bidid?
  bid.impid = imp.id;
- bid.price = ad.auth_bid_micros ? *ad.auth_bid_micros / 1000000.0 : ad.max_bid_micros / 1000000.0 ; // Not micros?
+ if constexpr (sizeof...(Processor) <= 0) {
+ bid.price =
+ ad.auth_bid_price ? *ad.auth_bid_price / 1000000.0 : ad.max_bid_micros / 1000000.0;
+ }
  bid.w = ad.width;
  bid.h = ad.height;
  bid.adm = ad.code;