Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for supplying a NSAttributedString for the token instead... #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BayPhillips
Copy link

... of a NSString. There are a couple ways this could be accomplished but I figured this would be the simplest and wouldn't interfere with current usages of it.

@BayPhillips
Copy link
Author

This is also in reference to #7

@BayPhillips
Copy link
Author

Looking into the tests break.

@ayanonagon
Copy link
Contributor

Hey! Taking a look at this now. Thanks for the pull request. :octocat: 👍

@BayPhillips
Copy link
Author

Was just looking over this now and I think I may have a bug with not applying the attributes to the comma in the attributed string!

@BayPhillips
Copy link
Author

I also realized there's a lot more that we need to support when adding NSAttributedString support.

  • How do we want the To field to look? Should it be the same size as the tokens?
  • We need to make sure the highlighted background view receives the same frame (with or without a padding?)
  • Should the input text be the same style as well? What about the collapse text?

Either way, I'm going to be working some more on this. Sorry for the delay.

@ayanonagon
Copy link
Contributor

No need to be sorry about anything! Really appreciate your help with this, @BayPhillips. Those are all really good questions. We don't do much customization at all for Venmo, so I'm curious to get input from other people who use this pod in terms of what is expected. Maybe the best thing to do is make is pretty flexible, we can apply individual styling to the collapsed, input, and token texts. It's tricky though, because the token field would look weird if the input style is really different from the token text, etc.

@BayPhillips
Copy link
Author

Yeah, that's definitely my primary concern. I'm thinking of having a default properties dictionary that gets applied to all of those texts. Allow users to overwrite the default styling, while also giving them additional properties for each one which if set, will be used. Keeping this backwards compatible for you guys and anyone else who uses the default styling is definitely my first priority.

@m1entus
Copy link

m1entus commented Apr 9, 2015

Please merge that ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants