Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README shows parens as optional on @*rule_variable declarations #25

Closed
wants to merge 1 commit into from
Closed

Conversation

ryboe
Copy link

@ryboe ryboe commented Jun 15, 2015

Without the parens on @numeric_rule_variable, the object is not a function and doesn't have a __name__ attribute. The README should emphasize that the parens are required. Otherwise, this happens:

  File "/usr/local/share/.virtualenvs/lib/python2.7/site-packages/business_rules/variables.py", line 35, in wrapper
    func = _memoize_return_values(func)
  File "/usr/local/share/.virtualenvs/lib/python2.7/site-packages/business_rules/variables.py", line 63, in _memoize_return_values
    @wraps(func)
  File "/usr/local/lib/python2.7/functools.py", line 33, in update_wrapper
    setattr(wrapper, attr, getattr(wrapped, attr))
AttributeError: 'TransactionVariable' object has no attribute '__name__'

@gregeinfrank
Copy link
Contributor

@y0ssar1an This was fixed in #17

This will be in the next release when it happens.

@akurihara - can you please push a new release?

@ryboe ryboe closed this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants