Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to allow user provided extensions #6

Closed
yogeshbdeshpande opened this issue Jul 30, 2021 · 1 comment
Closed

Add interface to allow user provided extensions #6

yogeshbdeshpande opened this issue Jul 30, 2021 · 1 comment

Comments

@yogeshbdeshpande
Copy link
Contributor

Problem Statement:

Present Implementation of Base CoRIM and CoMID has PSA specific types embedded into the base types.
One example is the Environment Type which has a Class Identifier object inside it.
One type of Class Identifier is the PSA Specific Implementation ID, which is PSA specific.
The issue it raises it:

  1. Now any external library user uses the Class ID object will get the PSA specific Implementation ID as part of
    the library implementation, which is not required.

  2. Any new user of CoRIM, CoMID library, if they have their own ID types, will eventually pollute the library with their own types.

Solution

  1. Create Generic Objects (like Class types) which has ONLY the base types (like OID and UUID).
  2. Provide mechanism for adding dynamic types from the caller with API's for:

a. Registration
b. Validator
c. Getter and Setter.
d. JSON and CBOR encoder and decoder

Additional context

None

@yogeshbdeshpande yogeshbdeshpande transferred this issue from veraison/veraison Sep 6, 2021
@thomas-fossati thomas-fossati changed the title Feature: Enhancement to decouple specific profile implementations from Base CoRIM and CoMID Add interface to allow user provided extensions Sep 16, 2021
@yogeshbdeshpande
Copy link
Contributor Author

Closing this as, now addressed using:

#96

deeglaze added a commit to deeglaze/corim that referenced this issue Oct 25, 2024
Top level tags are not interpretable as a COSE object.
Also support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 25, 2024
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 29, 2024
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
deeglaze added a commit to deeglaze/corim that referenced this issue Oct 29, 2024
Top level tags are not interpretable as a COSE object.
The protected header content-type is not meant to be
application/rim+cbor according to the spec draft (Issue veraison#132).

Support the spec's optional unsigned corim tag in COSE payload.

Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant