-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freshness + challenge-response nonce sizes #48
Conversation
Add extensions for temporary/working files generated by draw.io to .gitignore Signed-off-by: setrofim <setrofim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. A few typos fixed inline.
2db651a
to
848efa2
Compare
@setrofim. thank you for the change, I will review the rest a bit later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for very well formed draft.
I have made few comments, please do check and take it, if you agree! Otherwise good to go!
@setrofim All looks good and we are fine to merge. Just one quick question: In the sequence diagram, for comparison diamond, we depict session == evidence. I know due to space constraint it is done like that, was just curious shall we say something like and qualify somewhere below: and WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMO that would make it more confusing as it's not obvious what "s" and "ev" decode to. Conversely, the entire diagram is about the nonce/challenge -- the inputs going into comparison are nonces. |
Document Veraison mechanisms for ensuring evidence freshness. Signed-off-by: setrofim <setrofim@gmail.com>
Document limitations for the nonce and nonceSize parameters for /newSession requests. Signed-off-by: setrofim <setrofim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Document Veraison approach to handling evidence freshness and update challenge-response docs with nonce size restriction.