NewSigner handle unsupported key types

veraison · May 12, 2018 · f6f30b1 · f6f30b1
1 parent 69e95cb
commit f6f30b1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/core.go b/core.go
@@ -84,7 +84,9 @@ func NewSigner(alg *Algorithm, options interface{}) (signer *Signer, err error)
 			err = errors.Wrapf(err, "error generating rsa signer private key")
 			return nil, err
 		}
-	}
+	} else {
+                return nil, ErrUnknownPrivateKeyType
+        }
 
 	return &Signer{
 		privateKey: privateKey,

diff --git a/core_test.go b/core_test.go
@@ -123,7 +123,11 @@ func TestVerifyRSASuccess(t *testing.T) {
 func TestVerifyInvalidAlgErrors(t *testing.T) {
 	assert := assert.New(t)
 
-	signer, err := NewSignerFromKey(ES256, &ecdsaPrivateKey)
+	signer, err := NewSigner(getAlgByNameOrPanic("EdDSA"), nil)
+	assert.NotNil(err)
+	assert.Equal(err.Error(), ErrUnknownPrivateKeyType.Error())
+
+	signer, err = NewSignerFromKey(ES256, &ecdsaPrivateKey)
 	assert.Nil(err, "Error creating signer")
 
 	verifier := signer.Verifier()