Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance review #52

Closed
4 tasks
qmuntal opened this issue Apr 20, 2022 · 4 comments
Closed
4 tasks

Performance review #52

qmuntal opened this issue Apr 20, 2022 · 4 comments
Milestone

Comments

@qmuntal
Copy link
Contributor

qmuntal commented Apr 20, 2022

We should benchmark the go-cose public API to see where we are in terms of memory allocation and throughput.
With these metrics we will be able to evaluate if we need to invest resources on improving the performance.

While benchmarking we should treat the algorithm as an invariant, even one that does nothing, so we only benchmark things that are under our control.

This is an umbrella issue to track the benchmarking effort.

  • Sign1Message.MarshalCBOR
  • Sign1Message.UnmarshalCBOR
  • Sign1Message.Sign
  • Sign1Message.Verify
    - [ ] SignMessage.MarshalCBOR
    - [ ] SignMessage.UnmarshalCBOR
    - [ ] SignMessage.Sign
    - [ ] SignMessage.Verify
@SteveLasker
Copy link
Contributor

What are the latest thoughts about supporting or deprecating sign in lieu of sign1?

This was referenced Apr 21, 2022
@SteveLasker
Copy link
Contributor

sign has been disabled, to focus on sign1 at this point in time.

@SteveLasker SteveLasker modified the milestone: v1.0.0-RC1 Jul 1, 2022
@SteveLasker
Copy link
Contributor

We'll close this as the latest security review is published.

@SteveLasker
Copy link
Contributor

Closing as the Trail of Bits security review has been posited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants