-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Sign1Message benchmarks #54
Conversation
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (and useful) to me, thanks!
I have inlined a small editorial comment.
bench_test.go
Outdated
type zeroReader struct{} | ||
|
||
func (zeroReader) Read(b []byte) (int, error) { | ||
for i := range b { | ||
b[i] = 0 | ||
} | ||
return len(b), nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a dup of zeroSource
in conformance_test.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
Few General comments: |
I plan to stick with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds benchmarks for
Sign1Message
methods. These benchmarks will be useful later one to do memory and cpu profiling.These are the results on my Windows laptop (use only for reference):
For #52