Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite interface{} to any #162

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Rewrite interface{} to any #162

merged 2 commits into from
Aug 8, 2023

Conversation

qmuntal
Copy link
Contributor

@qmuntal qmuntal commented Aug 1, 2023

Using any instead of interface{} makes the code cleaner.

Command: gofmt -w -r "interface{} -> any" .

@qmuntal
rewrite interface{} to any
6ba5ad2 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
revert line ending change
2624ab0 
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
@qmuntal
Copy link
Contributor Author

qmuntal commented Aug 8, 2023

@yogeshbdeshpande PTAL

yogeshbdeshpande
yogeshbdeshpande approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had looked at it, but forgot to approve. Now approving it!
LGTM!

@qmuntal qmuntal merged commit ed78bf9 into main Aug 8, 2023
5 checks passed
@qmuntal qmuntal deleted the any branch August 8, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@setrofim setrofim setrofim approved these changes

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qmuntal @setrofim @yogeshbdeshpande