Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign1 bells and whistles #2

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Sign1 bells and whistles #2

merged 4 commits into from
Nov 25, 2020

Conversation

thomas-fossati
Copy link
Contributor

@thomas-fossati thomas-fossati commented Nov 24, 2020 •
edited
Loading

  • check all preconditions are met on Sign1 messages sent for signature & verification
  • add Sign1 example code
  • add further tests
  • update README with information about the fork and a pointer to the Sign1 example
  • add Sign1 specific error codes

SimonFrost-Arm
SimonFrost-Arm approved these changes Nov 25, 2020
View reviewed changes
Copy link

@SimonFrost-Arm SimonFrost-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-fossati thomas-fossati merged commit de93f60 into master Nov 25, 2020
@thomas-fossati thomas-fossati deleted the precond branch March 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrost-Arm SimonFrost-Arm SimonFrost-Arm approved these changes

@setrofim setrofim setrofim approved these changes

@mangup01 mangup01 Awaiting requested review from mangup01

@yogeshbdeshpande yogeshbdeshpande Awaiting requested review from yogeshbdeshpande

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas-fossati @setrofim @SimonFrost-Arm