Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme with release info #65

Merged
merged 1 commit into from
May 10, 2022
Merged

Update readme with release info #65

merged 1 commit into from
May 10, 2022

Conversation

SteveLasker
Copy link
Contributor

Signed-off-by: Steve Lasker stevenlasker@hotmail.com

shizhMSFT
shizhMSFT approved these changes May 7, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yogeshbdeshpande
yogeshbdeshpande reviewed May 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
yogeshbdeshpande
yogeshbdeshpande reviewed May 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
yogeshbdeshpande
yogeshbdeshpande reviewed May 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@thomas-fossati
Copy link
Contributor

I am slightly confused. In the README, we previously had warnings around the SignMessage interface being experimental. Unless I'm looking at the wrong file, they seem to have disappeared? Help me understand :-)

@yogeshbdeshpande
Copy link
Contributor

I am slightly confused. In the README, we previously had warnings around the SignMessage interface being experimental. Unless I'm looking at the wrong file, they seem to have disappeared? Help me understand

@thomas-fossati This has happened because Steve has raised a PR from this fork, which is not rebased to latest on master(main) go-cose.

He need to do that before he merges to master and retain the change you have done in the previous commit.

@SteveLasker
Copy link
Contributor Author

Ahhh, thank you for the catch, i’ll fix later today.
@yogeshbdeshpande, looks like a DCO error got introduced.

@SteveLasker @yogeshbdeshpande
Update readme with release info
cece68c 
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
@yogeshbdeshpande yogeshbdeshpande merged commit 84fb267 into veraison:main May 10, 2022
@SteveLasker SteveLasker deleted the alpha1-prep branch May 10, 2022 21:54
@SteveLasker
Copy link
Contributor Author

Thank you @yogeshbdeshpande

@SteveLasker SteveLasker mentioned this pull request May 10, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@yogeshbdeshpande yogeshbdeshpande yogeshbdeshpande approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveLasker @thomas-fossati @yogeshbdeshpande @shizhMSFT