Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying JWT header when signing #29

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

setrofim
Copy link
Contributor

@setrofim setrofim commented Nov 5, 2024

  • Add alternative versions of signing methods that take a jwt::Header instead of an algorithm.
  • Add new_jwt_header helper function that creates a new jwt::Header from an Algorithm.

This addresses #23

@setrofim
Copy link
Contributor Author

setrofim commented Nov 5, 2024

CC @Xynnn007

Copy link
Contributor

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for the feature! LGTM

Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(There's also a CWT side of this story, right? If so, it can be deferred, but we need to track it in an issue.)

README.md Outdated Show resolved Hide resolved
- Add alternative versions of signing methods that take a jwt::Header
  instead of an algorithm.
- Add `new_jwt_header` helper function that creates a new jwt::Header
  from an Algorithm.

Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
@setrofim setrofim merged commit fa2839f into main Nov 6, 2024
4 checks passed
@setrofim setrofim deleted the jwt-header branch November 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants