fix(#70, #132, #159, #316, #369): platform compatibility#448
Open
giulio-leone wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(#70, #132, #159, #316, #369): platform compatibility#448giulio-leone wants to merge 1 commit intovercel-labs:mainfrom
giulio-leone wants to merge 1 commit intovercel-labs:mainfrom
Conversation
… shutdown improvements - vercel-labs#212: Check browser.isConnected() + persistent context state in isLaunched() - vercel-labs#378: Reworked shutdown with timeouts, force-exit, shuttingDown guard - vercel-labs#395: flush_and_exit() replaces exit(1) to prevent terminal freeze
Contributor
|
@g97iulio1609 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Feb 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform Compatibility Improvements (Group 5)
Bundles five platform-compatibility fixes that address root/container detection, Windows port binding, Windows UI behavior, Linux socket directory validation, and environment variable forwarding.
Issues Addressed
--no-sandboxwhen running as root in containerssrc/browser.tsEACCESwhen binding Windows TCP portsrc/daemon.ts,cli/src/connection.rsCREATE_NO_WINDOWcli/src/connection.rsXDG_RUNTIME_DIRwritability, fallback to~/.agent-browsersrc/daemon.ts,cli/src/connection.rs,cli/src/main.rssrc/browser.tsChanges
process.getuid() === 0and automatically appends--no-sandboxto Chromium launch args, preventing the "Running as root without --no-sandbox" crash in Docker/CI containers.EACCESerrors on Windows, where ephemeral port conflicts can cause transient permission failures.CREATE_NO_WINDOW(0x08000000) to Windows process creation flags alongsideCREATE_NEW_PROCESS_GROUPandDETACHED_PROCESSto suppress the visible cmd.exe console window.XDG_RUNTIME_DIRfor the Unix socket, validates the directory exists and is writable; falls back to~/.agent-browserif not. Also adds the validation in the Rust CLI side.env: { ...process.env }to browser subprocess launch calls so that proxy settings,PATH, and other environment variables are correctly inherited.Testing
npx tsc --noEmit— passescargo check(cli) — passesRelated