fix(#310): support vscode-webview:// origin + custom allowed origins#463
Open
giulio-leone wants to merge 2 commits intovercel-labs:mainfrom
Open
fix(#310): support vscode-webview:// origin + custom allowed origins#463giulio-leone wants to merge 2 commits intovercel-labs:mainfrom
giulio-leone wants to merge 2 commits intovercel-labs:mainfrom
Conversation
Contributor
|
@g97iulio1609 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310
Problem
VSCode Webview extensions use
vscode-webview://as their Origin header, which was rejected by the stream server's origin validation.Solution
vscode-webview://as a default allowed origin inisAllowedOrigin()setAllowedOrigins()for custom origin supportAGENT_BROWSER_ALLOWED_ORIGINSenv var (comma-separated list)--allow-originsCLI flag passed to daemonThis enables VSCode extensions and other non-browser clients to connect to the stream server.