Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-mugs-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'ai': patch
---

fix not catching of empty arrays in validateUIMessage
76 changes: 76 additions & 0 deletions packages/ai/src/ui/validate-ui-messages.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,55 @@ describe('validateUIMessages', () => {
[AI_InvalidArgumentError: Invalid argument for parameter messages: messages parameter must be provided]
`);
});

it('should throw TypeValidationError when messages array is empty', async () => {
await expect(
validateUIMessages({
messages: [],
}),
).rejects.toThrowErrorMatchingInlineSnapshot(`
[AI_TypeValidationError: Type validation failed: Value: [].
Error message: [
{
"origin": "array",
"code": "too_small",
"minimum": 1,
"inclusive": true,
"path": [],
"message": "Messages array must not be empty"
}
]]
`);
});

it('should throw TypeValidationError when message has empty parts array', async () => {
await expect(
validateUIMessages({
messages: [
{
id: '1',
role: 'user',
parts: [],
},
],
}),
).rejects.toThrowErrorMatchingInlineSnapshot(`
[AI_TypeValidationError: Type validation failed: Value: [{"id":"1","role":"user","parts":[]}].
Error message: [
{
"origin": "array",
"code": "too_small",
"minimum": 1,
"inclusive": true,
"path": [
0,
"parts"
],
"message": "Message must contain at least one part"
}
]]
`);
});
});

describe('metadata', () => {
Expand Down Expand Up @@ -1158,6 +1207,33 @@ describe('safeValidateUIMessages', () => {
);
});

it('should return failure result when messages array is empty', async () => {
const result = await safeValidateUIMessages({
messages: [],
});

expectToBe(result.success, false);
expect(result.error.name).toBe('AI_TypeValidationError');
expect(result.error.message).toContain('Type validation failed');
expect(result.error.message).toContain('Messages array must not be empty');
});

it('should return failure result when message has empty parts array', async () => {
const result = await safeValidateUIMessages({
messages: [
{
id: '1',
role: 'user',
parts: [],
},
],
});

expectToBe(result.success, false);
expect(result.error.name).toBe('AI_TypeValidationError');
expect(result.error.message).toContain('Type validation failed');
});

it('should return failure result when metadata validation fails', async () => {
const result = await safeValidateUIMessages<UIMessage<{ foo: string }>>({
messages: [
Expand Down
Loading
Loading