Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (provider/openai): send user message content as text when possible #1765

Merged
merged 12 commits into from
May 30, 2024
Merged

feat (provider/openai): send user message content as text when possible #1765

merged 12 commits into from
May 30, 2024

Conversation

lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented May 30, 2024 •
edited
Loading

Summary

  • when there is only a single text part in a user message, send the content as a string
  • remove object: z.literal('chat.completion') check on chat response schema

Tasks

  • implementation
  • tests
  • changeset

@lgrammel lgrammel self-assigned this May 30, 2024
@lgrammel lgrammel mentioned this pull request May 30, 2024
Closed
@lgrammel lgrammel marked this pull request as ready for review May 30, 2024 16:27
@lgrammel lgrammel merged commit fb42e76 into main May 30, 2024
7 checks passed
@lgrammel lgrammel deleted the lg/1755 branch May 30, 2024 16:45
@lgrammel lgrammel mentioned this pull request May 30, 2024
Closed
Rajaniraiyn pushed a commit to Rajaniraiyn/ai that referenced this pull request Jun 1, 2024
@lgrammel @minpeter @Rajaniraiyn
feat (provider/openai): send user message content as text when possib…
f89d146 
…le (vercel#1765)

Co-authored-by: minpeter <minpeter@friendli.ai>
Co-authored-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lgrammel lgrammel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgrammel @minpeter