chore (docs): improve example content, highlighting & install snippets #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrammel
reviewed
Jun 2, 2024
| forecast, | ||
| }} | ||
| /> | ||
| <WeatherCard weather={weather} /> |
There was a problem hiding this comment.
this will affect the highlighting (line 158) which needs to be updated
There was a problem hiding this comment.
oh you are right, fixed
|
thank you! |
|
I've also added a fix to remove an unused import that might create confusion (at least it did for me) about if that was needed or not and also typed the |
|
Added tabs to install the dependencies with the different package managers (to be consistent with other parts of the documentation like https://sdk.vercel.ai/docs/ai-sdk-core/schemas-and-zod) |
agusmoles
changed the title
lgrammel
approved these changes
Jun 3, 2024
lgrammel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, I was going through the documentation of the Vercel AI SDK for RSC and I think these changes were wrong in the original documentation, as we were obtaining the data from the
getWeatherexternal function, destructuring thecontentbut then not using the returned variables since the attributes are being hardcoded in thereturnstatement of each oneLet me know if I got something wrong. Great tool and documentation btw! 😄
EDIT: made some more updates, described below (and in the commit msgs)