Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (vue/react/solid/svelte): usechat restore the previous message #2086

Closed
wants to merge 4 commits into from
Closed

fix (vue/react/solid/svelte): usechat restore the previous message #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0087d3
fix (vue/react/solid/svelte): usechat restore the previous message
AntzyMo Jun 25, 2024
0e4857d
Merge branch 'main' into fix--usechat-restore-the-previous-message
AntzyMo Jun 25, 2024
ee2376b
Merge branch 'main' into fix--usechat-restore-the-previous-message
AntzyMo Jun 25, 2024
f43ac89
Merge branch 'main' into fix--usechat-restore-the-previous-message
AntzyMo Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const getStreamedResponse = async (
) => {
// Do an optimistic update to the chat state to show the updated messages
// immediately.
const previousMessages = messagesRef.current;
const previousMessages = chatRequest.messages;
mutate(chatRequest.messages, false);

const constructedMessagesPayload = sendExtraMessageFields
Expand Down
6 changes: 2 additions & 4 deletions packages/solid/src/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export function useChat({

// Do an optimistic update to the chat state to show the updated messages
// immediately.
const previousMessages = getCurrentMessages();
const previousMessages = messagesSnapshot;
mutate(messagesSnapshot);

let chatRequest: ChatRequest = {
Expand Down Expand Up @@ -190,9 +190,7 @@ export function useChat({
onFinish,
restoreMessagesOnFailure() {
// Restore the previous messages if the request fails.
if (previousMessages.status === 'success') {
mutate(previousMessages.data);
}
mutate(previousMessages);
},
generateId,
});
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/src/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export function useChat({
},
get(streamData),
extraMetadata,
get(messages),
chatRequest.messages,
abortController,
generateId,
streamMode,
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/use-chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function useChat({

// Do an optimistic update to the chat state to show the updated messages
// immediately.
const previousMessages = messagesData.value;
const previousMessages = messagesSnapshot;
mutate(messagesSnapshot);

let chatRequest: ChatRequest = {
Expand Down
Loading