Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (ai/core): only append assistant response at the end when there is a final user message #4623

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix (ai/core): only append assistant response at the end when there is a final user message #4623

merged 1 commit into from
Jan 31, 2025

Conversation

lgrammel
Copy link
Collaborator

Fixes #4619

@lgrammel lgrammel merged commit ca89615 into main Jan 31, 2025
9 checks passed
@lgrammel lgrammel deleted the lg/V7Y8hR branch January 31, 2025 09:55
@rclmenezes
Copy link

Thanks -- you're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoalbanese nicoalbanese nicoalbanese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convertToCoreMessages now returns message content after tools, breaking subsequent LLM calls
3 participants
@lgrammel @rclmenezes @nicoalbanese