-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore(repo): make clean scripts cross-platform (replace rm -rf with del-cli) #8497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gr2m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tayyab3245! CI is currently failing and there is a merge conflict, could you please look at these? Let me know if you need any help
e6d7ef2 to
45ded77
Compare
…el-cli) Fixes vercel#8496 - Updated all package.json clean scripts: rm -rf del-cli - Added del-cli as dev dependency at workspace root - No runtime code changes, dev-only cross-platform fix - Verified on Windows: clean/build/test now work vs previous rm errors
45ded77 to
2973992
Compare
|
Hi @gr2m, I've updated the PR and completed the investigation into the CI failures. This PR's Fix: This PR correctly fixes the Windows build-blocker #8496 by replacing rm -rf with del-cli. This is a necessary change for cross-platform compatibility. CI Test Failures: The CI failures are caused by a separate, pre-existing issue (#8469) related to how test utilities import vitest. This is unrelated to the changes in this PR. My initial bug report (#8518) incorrectly diagnosed this as a React version mismatch, but we've since confirmed #8469 is the true root cause. This PR is ready for review. It resolves the critical build failure, and the remaining CI errors are tracked by the separate issue. |
gr2m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry it took so long. Thank you again for your contributions!
|
|
Fixes #8496
Background
On Windows,
rmis not available by default, causing all clean/build/test commands to fail with'rm' is not recognized as an internal or external command. This completely blocks Windows contributors and CI runners from using the development toolchain.The issue affects 40+ packages across the monorepo, all using
rm -rfin their clean scripts. @gr2m recommended thedel-cliapproach in the issue comments.Summary
Replaced Unix-only
rm -rfcommands with cross-platformdel-cliin all package.json clean scripts:"clean": "rm -rf dist *.tsbuildinfo""clean": "del-cli dist *.tsbuildinfo"Added
del-clias a dev-only dependency at the workspace root. No runtime code changes, no published API changes.Manual Verification
Before this PR (Windows PowerShell):
After this PR (Windows PowerShell):
Cross-platform verification:
Tasks
pnpm changesetin the project root)pnpm prettier-fixin the project root)Future Work
None required. This is a complete fix for the Windows compatibility issue.
Related Issues
Fixes #8496