Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Saleor Provider #356

Merged
merged 56 commits into from
Jun 10, 2021
Merged

Updated Saleor Provider #356

merged 56 commits into from
Jun 10, 2021

Conversation

zaiste
Copy link
Contributor

@zaiste zaiste commented Jun 5, 2021

This PR supersedes the #277 It also incorporates the changes introduced by #252 Overall, this PR provides a minimal working example showing how to integrate Saleor with the Next.js Commerce platform.

cc @patrys @okbel

Additionally, I've updated a couple of dependencies (package.json) - leaving Next.js at 10.0.9-canary.5 because of issues that prevent images to be properly displayed cc @lfades

@vercel
Copy link

vercel bot commented Jun 5, 2021

@zaiste is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

commerce-bigcommerce – ./

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-bigcommerce/AJLujCexxQQgqx3gds2JbpyQsJ1V
✅ Preview: Failed

commerce-shopify – ./

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-shopify/3LQVSZVCa6cUxNM6MJP777viDWRS
✅ Preview: Failed

commerce-swell – ./

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-swell/DRy6844mA3yZDKg3LJ6JAbxHE7zn
✅ Preview: Failed

commerce-vendure – ./

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-vendure/6N5AkqMzTyAbRtQqmekN2WnHCof2
✅ Preview: Failed

@lfades
Copy link
Member

lfades commented Jun 7, 2021

@zaiste What's the issue that prevents us from being on the latest Next.js version? 10.0.9 is quite behind

@zaiste
Copy link
Contributor Author

zaiste commented Jun 7, 2021

@lfades Images didn't appear in production for any version of Next.js after the current one if I recall correctly. I can investigate further as I'd also prefer to be on the latest Next.js version here.

This could be fixed in the following PR so it doesn't block the Saleor provider if that's OK for you

@lfades
Copy link
Member

lfades commented Jun 8, 2021

@zaiste Is that the case for the other providers or only for Saleor? 🤔

@zaiste
Copy link
Contributor Author

zaiste commented Jun 8, 2021

@lfades I haven't yet checked other providers. For clarity, currently, in this repository on the master branch, you use this older Next.js version i.e. 10.0.9-canary.5 (ref). In this PR, I decided to leave the Next.js version unchanged. We could address the Next.js upgrade in the following PR to make sure it works correctly for all providers across the board.

@lfades lfades merged commit 3b2bf65 into vercel:master Jun 10, 2021
loan-laux pushed a commit to TrellisCommerce/next-commerce-bigcommerce that referenced this pull request May 11, 2023
* Initial work, copied from the Shopify provider

* Added basis setup and type generation for the products queries

* refactor: adjust the types

* task: relax the Node.js constraint

* fix: page/product properties

* disable unknown fields

* mention Saleor in the README

* setup debugging for Next.js

* Check nextjs-commerce bug if no images are added for a product

* fix: client/server pecularities for env visibility

Must prefix with `NEXT_PUBLIC_` so that the API URL is
visible on the client

* re: make search work with Saleor API (WIP)

* task: update deps

* task: move to Webpack 5.x

* saleor: initial cart integration

* update deps

* saleor: shall the cart appear!

* task: remove deprecated packages

* saleor: adding/removing from the cart

* saleor: preliminary signup process

* saleor: fix the prices in the cart

* update deps

* update deps

* Added the options for a variant to the product page

* Mapped options to variants

* Mapped options to variants

* saleor: refine the auth process

* saleor: remove unused code

* saleor: handle customer find via refresh

temporary solution

* saleor: update deps

* saleor: fix the session handling

* saleor: fix the variants

* saleor: simplify the naming for GraphQL statements

* saleor: fix the type for collection

* saleor: arrange the error codes

* saleor: integrate collections

* saleor: fix product sorting

* saleor: set cookie location

* saleor: update the schema

* saleor: attach checkout to customer

* saleor: fix the checkout flow

* saleor: unify GraphQL naming approach

* task: update deps

* Add the env variables for saleor to the template

* task: prettier

* saleor: stub API for build/typescript compilation

thanks @cond0r

* task: temporarily disable for the `build`

* saleor: refactor GraphQL queries

* saleor: adjust the config

* task: update dependencies

* revert: Next.js to `10.0.9`

* saleor: fix the checkout fetch query

* task: update dependencies

* saleor: adapt for displaying featured products

* saleor: update the provider structure

* saleor: make the home page representable

* feature/cart: display the variant name (cond)

Co-authored-by: Patryk Zawadzki <patrys@room-303.com>
Co-authored-by: royderks <10717410+royderks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants