Add initial Windows support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rename()` step causes issues on Windows related to anti-virus software (i.e. Windows Defender). It's essentially the same issue as: expo/create-react-native-app#191
We can't assume that `bash` is present on Windows.
`SIGSTOP`/`SIGCONT` is not supported on Windows
For some reason, on Windows if the file already exists then Node.js exits without printing anything…
styfle
reviewed
May 2, 2019
| const bootstrap = join(runtime.cacheDir, 'bootstrap'); | ||
| const bootstrap = join( | ||
| runtime.cacheDir, | ||
| isWin ? 'bootstrap.js' : 'bootstrap' |
There was a problem hiding this comment.
Why not always use bootstrap.js? Why is Windows different here?
There was a problem hiding this comment.
This is so bizarre that it would definitely warrant a comment
There was a problem hiding this comment.
Basically there's two implementations of these "bootstrap" logic. Ideally just temporarily, and we use the .js ones for all platforms, but for now running the .js ones on unix was causing tests to fail. So consider this just an in-progress transition to that while we get Windows initially/incrementally working.
styfle
approved these changes
May 2, 2019
|
Is Windows CI working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATHenv var delimiter for Windows (;vs.:)bootstrap.jsfiles using Node because we can't rely onshbeing availablenodejs-related runtimes are working at the moment, hence initial Windows support