Add ZEIT_FUN_NODE_MIRROR ENV for node.js tarball mirror support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
reviewed
Aug 30, 2019
src/install-node.ts
Outdated
| @@ -25,7 +25,14 @@ export function generateNodeTarballUrl( | |||
| } else { | |||
| ext = 'tar.gz'; | |||
| } | |||
| return `https://nodejs.org/dist/${version}/node-${version}-${plat}-${arch}.${ext}`; | |||
|
|
|||
| let mirror = process.env.ZEIT_FUN_MIRRORS_NODE; | |||
There was a problem hiding this comment.
I would prefer the name to be:
Suggested change
| let mirror = process.env.ZEIT_FUN_MIRRORS_NODE; | |
| let mirror = process.env.ZEIT_FUN_NODE_MIRROR; |
|
I am potentially ok with this change, however it needs a test case. |
luoyjx
changed the title
|
@TooTallNate Thanks for replying! I rename the ENV from 'ZEIT_FUN_MIRRORS_NODE' to 'ZEIT_FUN_NODE_MIRROR' and add test for this feature. |
luoyjx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will be good for me :)