Issues spotted at GF onboarding time revision

[vv-monsalve]

Font Name (Geist Sans/Geist Mono):

• Geist Sans
• Geist Mono

During the last onboarding review, my colleague @emmamarichal and I noticed some areas that need improvement.

Cyrillic

While Cyrillic is not among the base standard requirements for submitted fonts in GF, please consider making the following adjustments.

• Please review the connection (the descender is not well attached) and the vertical position of the following glyphs ҖҚҢҲҶҗқңҳҷ:

• The bar could be better centered:

Kerning

• The Cyrillic kerning could be improved:

[vv-monsalve]

Monospace issues

• Most ligatures tested are working ok but

  • <---
  
  • ###

• Alignment issue
  The glyph could be decomposed as in the proportional Geist. It's highly suggested not to combine components with paths.

[vv-monsalve]

Small adjustments

• Please review the currency position throughout the masters,

• The comma could be centered with the T stem:

[vv-monsalve]

Interpolation

• uhungarumlaut is not using the right component

[guidoferreyra]

Oh I did the same fixes, we commited almost at the same time 🤣

• Anyway, the cyrillic was not reviewed and requires a complete overhaul, nevertheless, I made the changes you asked.
• The two missing coding ligatures are left out from the feature because I couldn’t find evidence that those are used. Perhaps the glyphs should be not exported.

[vv-monsalve]

Oh I did the same fixes, we commited almost at the same time 🤣

I decided to make a PR to speed up 🫠

couldn’t find evidence that those are used. Perhaps the glyphs should be not exported.

Yes, please; in that case, it is better not to export them.

[vv-monsalve]

@guidoferreyra Please bring the additional changes I was including in the PR: the license URL change in the font info and the adjustment to: softsign-cy and yeru-cy

[vv-monsalve]

Perhaps the glyphs should be not exported.

Please remember to make the nonworking ligatures non-export.

[guidoferreyra]

Somehow I missed your comments on this issue. I will make these fixes asap.

[guidoferreyra]

@vv-monsalve The latest change on this branch https://github.com/vercel/geist-font/tree/%23135-fixes includes the fixes on the ligatures and yeru-cy

[vv-monsalve]

A couple of ligatures were missing to make it non-exportable. I've created a PR for the above branch, including them.

[vv-monsalve]

Anyway, the Cyrillic was not reviewed and requires a complete overhaul

We are going to delist the Cyrillic support to continue with the font's onboarding process as it is now.

We are seeing more issues regarding the Cyrillic. I'm leaving the added comments here so they can be addressed on an update of the font.

Cyrillic

• uni0409: this thicker stem was not here in the previous version

• very small connexion issue with the components:

• alignement issue:

[guidoferreyra]

This might be the typical GlyphsApp compoonent alignment that happens all the time. I can fix them but the cyrillic has other more big issues that should be adressed.