Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**FAIL** Overlaying path segments #139

Closed
2 tasks done
vv-monsalve opened this issue Oct 23, 2024 · 1 comment
Closed
2 tasks done

**FAIL** Overlaying path segments #139

vv-monsalve opened this issue Oct 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Oct 23, 2024

@guidoferreyra The following check was implemented after seeing some issues for outlines with coincident paths and it is reporting a Fails status for the Geist fonts

  • Geist Sans
🔥 FAIL Check there are no overlapping path segments

Some rasterizers encounter difficulties when rendering glyphs with
overlapping path segments.

A path segment is a section of a path defined by two on-curve points.
When two segments share the same coordinates, they are considered
overlapping.

Original proposal: google/fonts#7594 (comment)

  • 🔥 FAIL

    The following glyphs have overlapping path segments:

* uni0416 (U+0416): L<<616.0,355.0>--<500.0,355.0>> has the same coordinates as a previous segment.

* uni0416 (U+0416): L<<428.0,355.0>--<311.0,355.0>> has the same coordinates as a previous segment.

* uni041A (U+041A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni040C (U+040C): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<616.0,355.0>--<500.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<428.0,355.0>--<311.0,355.0>> has the same coordinates as a previous segment.

* uni049A (U+049A): L<<288.0,355.0>--<171.0,355.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<578.0,265.0>--<467.0,265.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<395.0,265.0>--<282.0,265.0>> has the same coordinates as a previous segment.

* uni043A (U+043A): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

* uni045C (U+045C): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<578.0,265.0>--<467.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<395.0,265.0>--<282.0,265.0>> has the same coordinates as a previous segment.

* uni049B (U+049B): L<<272.0,265.0>--<159.0,265.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

  • Geist Mono
🔥 FAIL Check there are no overlapping path segments

Some rasterizers encounter difficulties when rendering glyphs with
overlapping path segments.

A path segment is a section of a path defined by two on-curve points.
When two segments share the same coordinates, they are considered
overlapping.

Original proposal: google/fonts#7594 (comment)

  • 🔥 FAIL

    The following glyphs have overlapping path segments:

* uni0416 (U+0416): L<<426.0,355.0>--<333.0,355.0>> has the same coordinates as a previous segment.

* uni0416 (U+0416): L<<267.0,355.0>--<174.0,355.0>> has the same coordinates as a previous segment.

* uni041A (U+041A): L<<248.0,355.0>--<137.0,355.0>> has the same coordinates as a previous segment.

* uni040C (U+040C): L<<248.0,355.0>--<137.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<409.0,355.0>--<320.0,355.0>> has the same coordinates as a previous segment.

* uni0496 (U+0496): L<<256.0,355.0>--<167.0,355.0>> has the same coordinates as a previous segment.

* uni049A (U+049A): L<<238.0,355.0>--<127.0,355.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<432.0,265.0>--<336.0,265.0>> has the same coordinates as a previous segment.

* uni0436 (U+0436): L<<264.0,265.0>--<168.0,265.0>> has the same coordinates as a previous segment.

* uni043A (U+043A): L<<283.0,265.0>--<170.0,265.0>> has the same coordinates as a previous segment.

* uni045C (U+045C): L<<283.0,265.0>--<170.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<432.0,265.0>--<336.0,265.0>> has the same coordinates as a previous segment.

* uni0497 (U+0497): L<<264.0,265.0>--<168.0,265.0>> has the same coordinates as a previous segment.

* uni049B (U+049B): L<<282.0,265.0>--<169.0,265.0>> has the same coordinates as a previous segment.

* asciitilde_at.liga: L<<-150.0,221.0>--<-150.0,143.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

Screenshot 2024-10-22 at 18 51 41
@vv-monsalve vv-monsalve added the bug Something isn't working label Oct 23, 2024
@guidoferreyra
Copy link
Collaborator

Oh this is a new check right? It was not reporting before I will fix it now.

@ZeeJab ZeeJab closed this as completed in f87d8f2 Oct 23, 2024
ZeeJab added a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants