Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper-arc-dark-controls #25

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Add hyper-arc-dark-controls #25

merged 3 commits into from
Apr 17, 2018

Conversation

moso
Copy link
Contributor

@moso moso commented Apr 16, 2018

No description provided.

@timothyis
Copy link
Contributor

Hi there @moso!

Thank you so much for the PR, I can't wait to merge this.
Firstly, could I request that you take a screenshot of the plugin at 2x density whilst being 600px in width (if possible)
Also, for me to merge this PR, we'd need the image to be solely of the plugin in Hyper, not including other plugins and themes (like hyper-statusline at the bottom of your image).
If the image could just be vanilla Hyper with your plugin, it'd be perfect 🤞

Once you have these things (and if you could rebase), I'd be happy to merge!

Sorry for not making this clear in the wiki, I'll work on that!

If you need any help with the image, let me know

@moso
Copy link
Contributor Author

moso commented Apr 17, 2018

Rebase done!

So you want one of those @2x images without being a real @2x?
I have uploaded a new screenshot with a slightly larger fontsize, inspired by looking at the latest submission of hyper-flat. It's the same size (600 x 2 = 1200), and clear of all other plugins.

If the image isn't okay, please do let me know 😄

@timothyis
Copy link
Contributor

Thank you 👍

@timothyis timothyis merged commit 1c2a7bb into vercel:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants