Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦄NEW: Add Shades-of-Purple theme #30

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Conversation

ahmadawais
Copy link
Contributor

@ahmadawais ahmadawais commented Apr 17, 2018

Add the json object for Shades-of-Purple theme 💜

I was asked on Twitter to add the theme here. So, fingers crossed. 🤞


Details:

image

Name: shades-of-purple-hyper
Description: Professional Hyper™ Terminal theme with hand-picked & bold shades of purple 💜 to go along with your command line usage. Love purple, coz. purple can be genius.

COLOR HEX
Background #2D2B55
Lite Purple #6943FF
Contrast Yello #FAD000
Contrast Pink #FF2C70
Shade of Purple #B362FF

Peace! ✌️

Add the `json` object for Shades-of-Purple theme
@markozxuu
Copy link
Contributor

@ahmadawais Hi, I see that you added a video, what are themes are static images, I know that this does not specify in this link but all themes that is in hyper store is following a design guideline like this.

hyper-solarized-light

@ahmadawais
Copy link
Contributor Author

ahmadawais commented Apr 17, 2018 via email

Copy link
Contributor

@timothyis timothyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ahmadawais! I'd be happy to accept this after the changes I've requested.

I haven't finished the wiki yet, but I'm adding guidelines and I don't think yours violates it in any way. The main thing is that the image should only show the theme and not any other plugin in Hyper.

plugins.json Outdated
"description": "Professional Hyper™ Terminal theme with hand-picked & bold shades of purple 💜 to go along with your command line usage. Love purple, coz. purple can be genius.",
"type": "theme",
"preview": "https://on.ahmda.ws/qvUU/c",
"colors": [,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma at the end here isn't valid json, please remove it 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

plugins.json Outdated
"#b362ff"
],
"dateAdded": "1523965034087"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you indent this by 2 spaces?

@ahmadawais
Copy link
Contributor Author

@timothyis I just fixed the silly mistakes. Apologies for that.

Review now :)

Also, I am not using any other plugins but just a simple script to show-off theme colors.

@timothyis timothyis merged commit 4cc68cc into vercel:master Apr 17, 2018
@timothyis
Copy link
Contributor

Thank you!

@ahmadawais
Copy link
Contributor Author

@timothyis Awesome! 💯
When will it go live on the site? Just wondering. Also, how does a theme gets featured? If mine did, I'd love to promote that to my Twitter and newsletter audience of 100,000+ developers.

Looking forward!
Peace! ✌️

@timothyis
Copy link
Contributor

@ahmadawais It'll go live today, I'm planning on making the release automatic.

For featured plugins/themes, we'll probably review them bi-weekly or monthly to decide which should be featured. We'll let you know though.

@ahmadawais
Copy link
Contributor Author

ahmadawais commented Apr 18, 2018 via email

@timothyis
Copy link
Contributor

Hi @ahmadawais. I've had to remove your theme from being listed for now due to an error with the image you submitted being flagged as phishing. Due to the preloading nature of the Hyper themes list, it caused the site to error when loading your image. If you'd like to submit a new link, I'd be happy to add it back.

@ahmadawais
Copy link
Contributor Author

Sure, I will do that. I use this service call https://www.getcloudapp.com/ and it has been used by some bad actors to do some bad shit which caused Google to penalize all of the links — such a d* move on Google's part to destroy millions of users and their online properties.

@ahmadawais ahmadawais deleted the patch-1 branch October 10, 2018 00:46
@ahmadawais
Copy link
Contributor Author

@timothyis all that needs to be done is to replace the image link with this

https://raw.githubusercontent.com/ahmadawais/Shades-of-Purple-Hyper/master/images/Shades-of-Purple-Hyper.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants