-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦄NEW: Add Shades-of-Purple theme #30
Conversation
Add the `json` object for Shades-of-Purple theme
@ahmadawais Hi, I see that you added a video, what are themes are static images, I know that this does not specify in this link but all themes that is in hyper store is following a design guideline like this. |
Mark you want me to change the screenshot?! It's written in the docs that
it can be a gif. Also restricting the screenshots to all look the same
would be limiting. Users mostly pick the themes based on how well and
different they're presented.
Thoughts?! 🙈👀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @ahmadawais! I'd be happy to accept this after the changes I've requested.
I haven't finished the wiki yet, but I'm adding guidelines and I don't think yours violates it in any way. The main thing is that the image should only show the theme and not any other plugin in Hyper.
plugins.json
Outdated
"description": "Professional Hyper™ Terminal theme with hand-picked & bold shades of purple 💜 to go along with your command line usage. Love purple, coz. purple can be genius.", | ||
"type": "theme", | ||
"preview": "https://on.ahmda.ws/qvUU/c", | ||
"colors": [, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comma at the end here isn't valid json, please remove it 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
plugins.json
Outdated
"#b362ff" | ||
], | ||
"dateAdded": "1523965034087" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you indent this by 2 spaces?
@timothyis I just fixed the silly mistakes. Apologies for that. Review now :) Also, I am not using any other plugins but just a simple script to show-off theme colors. |
Thank you! |
@timothyis Awesome! 💯 Looking forward! |
@ahmadawais It'll go live today, I'm planning on making the release automatic. For featured plugins/themes, we'll probably review them bi-weekly or monthly to decide which should be featured. We'll let you know though. |
Awesome 💯
Looking forward to it.
Peace! ✌️
|
Hi @ahmadawais. I've had to remove your theme from being listed for now due to an error with the image you submitted being flagged as phishing. Due to the preloading nature of the Hyper themes list, it caused the site to error when loading your image. If you'd like to submit a new link, I'd be happy to add it back. |
Sure, I will do that. I use this service call https://www.getcloudapp.com/ and it has been used by some bad actors to do some bad shit which caused Google to penalize all of the links — such a d* move on Google's part to destroy millions of users and their online properties. |
@timothyis all that needs to be done is to replace the image link with this
|
Add the
json
object for Shades-of-Purple theme 💜I was asked on Twitter to add the theme here. So, fingers crossed. 🤞
Details:
Name:
shades-of-purple-hyper
Description:
Professional Hyper™ Terminal theme with hand-picked & bold shades of purple 💜 to go along with your command line usage. Love purple, coz. purple can be genius.
Peace! ✌️