Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
@tibotiber unfortunately I have to undo this line because it was brea…
…king `vtop` and braille characters
- Loading branch information
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rauchg any details on how it is breaking vtop and braille? I'd like to get back into this and sort it out if I can. I see that the latest master still has unicode, emoji issues (#1332, #1336) but powerline line height is good (part of #1352). The unicode issue also breaks a powerline with a right section but in tmux and before returning only. See below a screenshot with all remaining problems:
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some context, I think I was not clear 😛. This is what I get running vtop and displaying braille with my version:
It's not obvious to me what is broken. You can also compare the 2 screenshots in tmux to see the issues.
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm strange. I don't think your font contains those braille characters potentially.
Need me to check anything?
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could post a screenshot of the expected behaviour, it would help a lot to understand what is wrong on my end. Thanks @MrRio.
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what's expected. Using
Menlo
@tibotiber it comes down to this: most fonts don't support braille characters. Menlo falls back to "Apple Braille", which is not a monospace font. The only way to handle that nicely is by forcing each character to be as wide as a menlo monospace character. Hence the CSS snippet
2e58e56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1536 should fix this