Skip to content

Commit

Permalink
@tibotiber unfortunately I have to undo this line because it was brea…
Browse files Browse the repository at this point in the history
…king `vtop` and braille characters
  • Loading branch information
rauchg committed Feb 16, 2017
1 parent 95141ac commit 2e58e56
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/hterm.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ hterm.Terminal.prototype.setFontSize = function (px) {
.unicode-node {
display: inline-block;
vertical-align: top;
width: ${this.scrollPort_.characterSize.width}px;
}
`;
};
Expand Down

6 comments on commit 2e58e56

@tibotiber
Copy link
Contributor

@tibotiber tibotiber commented on 2e58e56 Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauchg any details on how it is breaking vtop and braille? I'd like to get back into this and sort it out if I can. I see that the latest master still has unicode, emoji issues (#1332, #1336) but powerline line height is good (part of #1352). The unicode issue also breaks a powerline with a right section but in tmux and before returning only. See below a screenshot with all remaining problems:
shot

@tibotiber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context, I think I was not clear 😛. This is what I get running vtop and displaying braille with my version:
shot2
vtop
It's not obvious to me what is broken. You can also compare the 2 screenshots in tmux to see the issues.

@MrRio
Copy link
Contributor

@MrRio MrRio commented on 2e58e56 Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm strange. I don't think your font contains those braille characters potentially.

Need me to check anything?

@tibotiber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could post a screenshot of the expected behaviour, it would help a lot to understand what is wrong on my end. Thanks @MrRio.

@rauchg
Copy link
Member Author

@rauchg rauchg commented on 2e58e56 Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This is what's expected. Using Menlo
@tibotiber it comes down to this: most fonts don't support braille characters. Menlo falls back to "Apple Braille", which is not a monospace font. The only way to handle that nicely is by forcing each character to be as wide as a menlo monospace character. Hence the CSS snippet

@tibotiber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1536 should fix this

Please sign in to comment.