Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Sometimes when I do a full reload, the terminal becomes transparent #1026

Closed
2 tasks done
luisrudge opened this issue Nov 22, 2016 · 21 comments
Closed
2 tasks done
Labels
🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@luisrudge
Copy link

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10

  • Hyper.app version: 1.0.0 from appveyor

Issue

image

@matheuss
Copy link
Member

Whoa, that's weird. I never faced it 😰 Any extra info? Any plugins or themes?

@matheuss matheuss added 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Nov 22, 2016
@luisrudge
Copy link
Author

nope. fresh install

@Specro
Copy link
Contributor

Specro commented Nov 23, 2016

Same here. On full reload it becomes transparent. As if the background color wouldn't be applied or something like that. Everything else seems to be the same.
@matheuss Which element gets the background color of the terminal?

@ppot
Copy link
Contributor

ppot commented Nov 27, 2016

@luisrudge Could we see the console inspection if there is errors?

@haltcase
Copy link

I played with this a bit - there are no errors in the console. state.ui.backgroundColor has a value. It looks like the app's background color should come from electron's browser window property for it and I think that's where this is giving out. It's either a problem with BrowserWindow or the function Hyper is using to get the color value. Maybe the return value is invalid?

That's where I've gotten so far, hope it's on the right track.

@Lindenk
Copy link

Lindenk commented Nov 30, 2016

I also have this problem, but I'm running linux. I've built the latest version of master .

System info:

OS:         Arch Linux x64
WM:         bspwm
Compositor: compton

I've made the following changes to my config to help show what might be going on:

backgroundColor: 'rgba(0,0,0,0.6)',
showHamburgerMenu: true,

@mbeaudru
Copy link

I confirm this behaviour with the latest stable release 👍 fresh install, no plugins.

@stefanivic
Copy link
Contributor

stefanivic commented Dec 12, 2016

@matheuss I can also confirm this to happen on Windows 10 Pro and Hyper 1.0.0 ( I also had this issue on previous builds. )

@dotcypress
Copy link
Contributor

I'm not sure, but maybe this related to background bug when i open dev tools on mac?!

hyper-devtools

@amankkg
Copy link

amankkg commented Dec 13, 2016

Same bug only after trying some plugins on Win10 & v1.0.0. Removing of breaking plugin did not help.

@luckv
Copy link

luckv commented Dec 15, 2016

I have the same problem. I set:
backgroundColor: 'rgba(0,0,0,0.75)' (or with any alpha)
and when I do a full reload, or either closing and restarting the app, the background is black with the same alpha (I don't know wich, but I suppose 0.5) everytime. Sometimes it becomes totally transparent
hyper: 1.0.0
OS: Windows 10 Pro build 14393
node: 7.2.1
(Sorry for my bad markdown)

@GerjanOnline
Copy link

I am also experiencing this on my Windows 7 PC

@ppot ppot mentioned this issue Dec 18, 2016
@ppot
Copy link
Contributor

ppot commented Dec 18, 2016

Close in #1262

@ppot
Copy link
Contributor

ppot commented Dec 18, 2016

@luckv This is fixed in my previous comment PR

@damien122
Copy link

OS version and name: windows 10 x64

Hyper.app version: 1.0.0

I have also the same problem after trigger "Full Reload"

@sliepie
Copy link

sliepie commented Jan 5, 2017

I've done some research into finding what causes the transparent background on a full reload, and these are my initial findings:

Testcase:

  1. Set background color to rgba(255, 0, 0, 0.75) in hyper.js (setElectronBackgroundColor outputs #bfFF0000)
  2. Set initial background color to rgba(0, 0, 0, 0.75) (electron color #bf000000) in defaults for BrowserWindow constructor

Expected behavior

  1. Initial background for BrowserWindow is a red background color
  2. Background color will be black when BrowserWindow is shown. A flash of red -> black might be expected

Observed behavior

  1. Hyper launches with a black background, which flashes to almost instantly to red (nothing to worry about)
  2. Background stays red, when setBackgroundColor is called on init event

Conclusion

Enabling/disabling of transparency in options results in same behavior. There is one difference on a full reload; When transparency is enabled then the background of BrowserWindow turns transparent, if it's disabled then the background stays the same color as the backgroundColor option passed into the constructor of BrowserWindow.
At first glance this seems to be an issue with Electron, as it seems that Electron does nothing on the setBackgroundColor method call on Windows 10.
When I have some time this week, I will try to reproduce this problem with a simple Electron app. If that works out, we can log an issue on the Electron repo with our findings.

@TraceyK14
Copy link

@JarnoNijboer Yea let us know what you find. Just downloaded Hyper for windows and am seeing this issue as well.

@Stanzilla
Copy link
Contributor

It actually happens on every full reload.

@damien122
Copy link

this bug is the same like this -> #1638
Do the opposite of this solution and the full reload will work typically with build >= 1.3.1

@ghughes27
Copy link

ghughes27 commented Jun 13, 2017

Will be hard to recreate the process, but I was having the same issue when reloading hyper (on Windows 10 with bash.exe). Started playing around with the order plugins were loaded in the config file and now the full reload is working properly.

It could also be linked to the fact that I'm using a backgroundColor and termCSS: 'body {background-color: rgb(x,y,z)} with the default opacity of 1 if that helps.

Working with the following plugins and order:

...
plugins: [
  "hyper-statusline",
  "hyper-tabs-enhanced",
  "hyper-chesterish"
],
...

EDIT
Looks like after closing the config file, the full reload reverted to fully transparent :f\ Might have been a bug bc when it was working my fontFamily and backgroundColor was overriding the chesterish theme settings.

@Stanzilla Stanzilla mentioned this issue Jan 23, 2018
8 tasks
@albinekb
Copy link
Contributor

Fixed in v2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests