-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vibrancy effect changes on full reload #1146
Comments
colepeters
changed the title
Vibrancy effect changes on full plugin reload
Vibrancy effect changes on full reload
Dec 12, 2016
After searching a little bit more, wondering if #873 is related at all…? |
I bet that #1026 is related to this too 😎 |
@colepeters why did you close this? 🤔 |
Oops! Mistake. |
👌 @colepeters, I asked because your initial post was so good and descriptive 👍 thanks ❤️ |
This should be fixed now. Please re-open if I'm incorrect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
setVibrancy()
of the windowIssue
NB: I used the phrase 'full plugin reload' in the screenshots below, before realising it's just 'full reload'. Sorry for any confusion.
I’ve noticed that the effect of
setVibrancy()
changes when using a plugin which sets the vibrancy and doing a full reload. For example, here’s an instance of hyper with no customisations except for adding the hyper-simple-vibrancy plugin:If I now do a full reload (
Shift-Cmd-R
on macOS), then after the reload my window looks like this:Here’s another example using a theme plugin I’m working on locally. I’m setting the following relevant configs in my plugin:
With this plugin loaded, here’s what things look like when opening a new window:
However, after doing a full reload the background looks more vibrant:
I’ve tried inspecting for differences using the dev tools to see what might be happening to trigger the change in appearance after a full reload, but nothing’s grabbing my eye.
Interesting to note that after a basic reload (
Cmd-R
on macOS), there are no changes to the background. It’s only the full reload that triggers the change — then opening a new window goes back to the initial washed-out/less vibrant appearance.I’m happy to help solve this if I can, but I’m not really sure where to look. The vibrancy appearance after the full reload seems to be a lot more pleasing than the alternative, so if there’s a way to get it always looking that way without the full reload, that would be great.
Thanks as always for all the awesome work on Hyper, especially on shipping 1.0!
The text was updated successfully, but these errors were encountered: