Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vibrancy effect changes on full reload #1146

Closed
2 tasks done
colepeters opened this issue Dec 12, 2016 · 6 comments
Closed
2 tasks done

Vibrancy effect changes on full reload #1146

colepeters opened this issue Dec 12, 2016 · 6 comments

Comments

@colepeters
Copy link
Contributor

colepeters commented Dec 12, 2016

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS Sierra 10.12.1
  • Hyper.app version: 1.0.0
  • Link of a Gist with the contents of your .hyper.js: click here
  • Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A
  • The issue is reproducible in vanilla Hyper.app: No, this requires a plugin which sets the setVibrancy() of the window

Issue

NB: I used the phrase 'full plugin reload' in the screenshots below, before realising it's just 'full reload'. Sorry for any confusion.

I’ve noticed that the effect of setVibrancy() changes when using a plugin which sets the vibrancy and doing a full reload. For example, here’s an instance of hyper with no customisations except for adding the hyper-simple-vibrancy plugin:
image

If I now do a full reload (Shift-Cmd-R on macOS), then after the reload my window looks like this:
image

Here’s another example using a theme plugin I’m working on locally. I’m setting the following relevant configs in my plugin:

module.exports.onWindow = browserWindow => browserWindow.setVibrancy('ultra-dark');

module.exports.decorateConfig = config => {
  return Object.assign({}, config, {
    backgroundColor: 'rgba(41,43,46,0.666)',

With this plugin loaded, here’s what things look like when opening a new window:
image

However, after doing a full reload the background looks more vibrant:
image

I’ve tried inspecting for differences using the dev tools to see what might be happening to trigger the change in appearance after a full reload, but nothing’s grabbing my eye.

Interesting to note that after a basic reload (Cmd-R on macOS), there are no changes to the background. It’s only the full reload that triggers the change — then opening a new window goes back to the initial washed-out/less vibrant appearance.

I’m happy to help solve this if I can, but I’m not really sure where to look. The vibrancy appearance after the full reload seems to be a lot more pleasing than the alternative, so if there’s a way to get it always looking that way without the full reload, that would be great.

Thanks as always for all the awesome work on Hyper, especially on shipping 1.0!

@colepeters colepeters changed the title Vibrancy effect changes on full plugin reload Vibrancy effect changes on full reload Dec 12, 2016
@colepeters
Copy link
Contributor Author

After searching a little bit more, wondering if #873 is related at all…?

@dotcypress
Copy link
Contributor

I bet that #1026 is related to this too 😎

@albinekb
Copy link
Contributor

albinekb commented Sep 7, 2017

@colepeters why did you close this? 🤔

@colepeters
Copy link
Contributor Author

Oops! Mistake.

@colepeters colepeters reopened this Sep 7, 2017
@albinekb
Copy link
Contributor

albinekb commented Sep 7, 2017

👌 @colepeters, I asked because your initial post was so good and descriptive 👍 thanks ❤️

@timothyis
Copy link
Contributor

This should be fixed now. Please re-open if I'm incorrect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants