Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink is broken with line break #2923

Closed
2 tasks done
VdustR opened this issue Apr 24, 2018 · 4 comments
Closed
2 tasks done

Hyperlink is broken with line break #2923

VdustR opened this issue Apr 24, 2018 · 4 comments
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@VdustR
Copy link

VdustR commented Apr 24, 2018

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate
    I searched hyperlink, wrap

  • OS version and name: MacOS High Sierra 10.13.4

  • Hyper.app version: 2.0.0

  • Link of a Gist with the contents of your .hyper.js: as default

Issue

For example if the terminal show a very long URL and wrap like this

http://www.a.web.site/some/where/that/url/is/very/very/
long/

The hyperlink is http://www.a.web.site/some/where/that/url/is/very/very/, but the expected URL should be http://www.a.web.site/some/where/that/url/is/very/very/long/.

@albinekb
Copy link
Contributor

Looks like this has been fixed upstream in xterm: xtermjs/xterm.js#686, we just need to update our dependency 🤔

@albinekb albinekb added 🐛 Type: Bug Issue pertains to something wrong within Hyper 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself labels Apr 24, 2018
@bartveneman
Copy link

Was this dependency already updated?

@albinekb
Copy link
Contributor

We're waiting on #3214 @bartveneman

@BPScott
Copy link

BPScott commented Sep 24, 2018

The Canary version of Hyper is using xterm 3.4.1, which includes a fix for this. You can jump onto the canary build by adding the following to your hyper.js preferences updateChannel: 'canary,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests

5 participants