Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xterm to 3.7.0 Refs: #3178 #3214

Closed
wants to merge 1 commit into from
Closed

Upgrade xterm to 3.7.0 Refs: #3178 #3214

wants to merge 1 commit into from

Conversation

weichensw
Copy link

#2697 and #2793 both need a new version of xterm, and 3.7.0 just got released.

Copy link
Contributor

@albinekb albinekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@omgaz
Copy link

omgaz commented Sep 12, 2018

Also closes #3178

@jocull
Copy link

jocull commented Sep 14, 2018

This one should take precedence over #3178 👍

@JCMais
Copy link

JCMais commented Sep 14, 2018

Awesome, thank you @xbtsw

@weichensw
Copy link
Author

@albinekb There's no merge button available for me. Please kindly merge.

@dcalhoun
Copy link
Contributor

Would love to see this merged and published, as it will fix issues like jestjs/jest#6494.

@chabou
Copy link
Collaborator

chabou commented Sep 24, 2018

Yes, we need to merge this ASAP.

@weichensw weichensw closed this Oct 4, 2018
@weichensw weichensw reopened this Oct 4, 2018
@furudean
Copy link

furudean commented Oct 4, 2018

What is the status on this?

@albinekb
Copy link
Contributor

albinekb commented Oct 4, 2018

Waiting on someone else to approve, then we can merge. I have tested on macOS 10.12 and it works as expected.

@furudean
Copy link

furudean commented Oct 9, 2018

Can someone take a look at this? It's one line to approve 😓

@chabou
Copy link
Collaborator

chabou commented Oct 13, 2018

It doesn't work as expected with many opened panes.

How to reproduce:

  • Start Hyper. Type some characters. No problem.
  • Open a new pane (vertically or horizontally). Type some characters, no problem.
  • Give focus back on first pane, type some characters: they are duplicated.

I think there is some problem with term reattachment and listeners.
I'll try to debug this but help would be appreciated 🙌

Copy link
Collaborator

@chabou chabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate characters when many panes opened

@chabou
Copy link
Collaborator

chabou commented Oct 14, 2018

Thank you for your help @xbtsw 🙏

I'm am really sorry but this PR won't be merged 😞
Every xterm new version comes with some minor changes that should be addressed.
Due to the lack of real automatic tests in Hyper, updating xterm must be manually and heavily tested.

Closed in favor of #3255

@chabou chabou closed this Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants