Fix a bug related to the alpha hex calculation

[dkniffin]

I was running into an issue on OSX, where I'd set the backgroundColor to something like 'rgba(0, 0, 0, 0.8)', and everything would look great, until I closed Hyper, and re-opened it. Once I did that, it would still have transparency, but it'd be more transparent.

I tracked this down to the change I made. Basically, what was being done before is 0.8 would be converted to the decimal number 80, which is not correct. What should happen is that 0.8 should be a percentage of 100% opacity, which is 255, then converted to a hex string (via toString(16)). Hopefully that makes sense.

I'm not 100% sure, but I think this might also resolve #873, but I'd need @Lindenk to confirm.

[dkniffin]

Not sure if I should add this comment or not: // ┬──┬ ノ( ゜-゜ノ)

[Lindenk]

Well, the behavior is different this time. Rather than starting with an all white background, it looks normal until a reload, which might be what this fixes for me. Unfortunately transparency doesn't work at all now.

I'm running the default config with only the following hyper.js changes:

backgroundColor: 'rgba(0,0,0,0.6)',

showHamburgerMenu: true,

Well it was worth a try 😄

[Lindenk]

Wait wait, apparently this only seems to be a problem when running in dev mode. Also, it looks like --enable-transparent-visuals and --disable-gpu weren't passed to the app when running in dev mode. It seems to work correctly when fully built for release.

After a bit more playing around, doing a full reload sets the transparency to 0, but by default, it seems to run as expected.

[dkniffin]

@Lindenk So does this PR fix #873?

[Lindenk]

This seems to fix (the more important) half of the issue. I'll make a new issue on the remaining problem with full-reload, but otherwise, yes this PR does fix the majority of the problem. Thanks!

[SirTimmyTimbit]

Please can someone review this? I've been having the same problem on Windows 10 x64, Hyper 1.0.0.

[dkniffin]

Not exactly sure who has write access to this project, but looking at some recently merged PRs, @rauchg seems to. Would you mind taking a look over this and merging it? Thanks!

[ppot]

Can you rebase to latest master? @dkniffin

[dkniffin]

@ppot Done.